HDFS-17939. StripedReader should only scan data blocks when initializing zero stripe indices#8563
Open
CapMoon wants to merge 1 commit into
Open
HDFS-17939. StripedReader should only scan data blocks when initializing zero stripe indices#8563CapMoon wants to merge 1 commit into
CapMoon wants to merge 1 commit into
Conversation
Contributor
Author
|
@ZanderXu @kokonguyen191 masters, plz take a look when you are available |
…ing zero stripe indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HDFS-17939. StripedReader should only scan data blocks when initializing zero stripe indices
Description of PR
In StripedReader#initZeroStrip(), zeroStripeIndices is initialized by scanning all internal blocks, including parity blocks.
The loop should only scan data block indices, which would make the implementation match the meaning and allocated size of zeroStripeIndices, and avoid suggesting that parity block indices may be populated as zero stripe indices.
How was this patch tested?
Existing reconstruction tests already cover partial block groups where zero data strips are padded for decoding. The proposed change should not affect observable behavior, since parity indices are never valid zero stripe indices for non-empty block groups.