Skip to content

MAPREDUCE-6706. TaskUmbilicalProtocol to use ProtobufRPCEngine2 (#8422) (#8574)#8576

Merged
steveloughran merged 2 commits into
apache:branch-3.4from
steveloughran:pr/MAPREDUCE-6706-WritableEngine-branch-3.4
Jul 1, 2026
Merged

MAPREDUCE-6706. TaskUmbilicalProtocol to use ProtobufRPCEngine2 (#8422) (#8574)#8576
steveloughran merged 2 commits into
apache:branch-3.4from
steveloughran:pr/MAPREDUCE-6706-WritableEngine-branch-3.4

Conversation

@steveloughran

@steveloughran steveloughran commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

This moves the TaskUmbilicalProtocol between Mappers, Reducers and the MRAppMaster to using ProtobufRPCEngine2

Contains code written by Github Copilot

Contributed by Steve Loughran

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

…he#8422) (apache#8574)

This moves the TaskUmbilicalProtocol between Mappers, Reducers and the
MRAppMaster to using ProtobufRPCEngine2

Contains code written by Github Copilot

Contributed by Steve Loughran
@hadoop-yetus

Copy link
Copy Markdown

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 19m 8s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 buf 0m 1s buf was not available.
+0 🆗 buf 0m 1s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 7m 51s Maven dependency ordering for branch
+1 💚 mvninstall 46m 18s branch-3.4 passed
+1 💚 compile 2m 2s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 1m 52s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 26s branch-3.4 passed
+1 💚 mvnsite 2m 35s branch-3.4 passed
+1 💚 javadoc 2m 17s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 2m 5s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 46s branch-3.4 passed
+1 💚 shadedclient 38m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
-1 ❌ mvninstall 0m 17s /patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app in the patch failed.
-1 ❌ mvninstall 0m 19s /patch-mvninstall-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 ❌ compile 0m 45s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkUbuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client in the patch failed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.
-1 ❌ cc 0m 45s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkUbuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client in the patch failed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.
-1 ❌ javac 0m 45s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkUbuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client in the patch failed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.
-1 ❌ compile 0m 38s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkPrivateBuild-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.txt hadoop-mapreduce-client in the patch failed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.
-1 ❌ cc 0m 38s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkPrivateBuild-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.txt hadoop-mapreduce-client in the patch failed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.
-1 ❌ javac 0m 38s /patch-compile-hadoop-mapreduce-project_hadoop-mapreduce-client-jdkPrivateBuild-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.txt hadoop-mapreduce-client in the patch failed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 37s /buildtool-patch-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt The patch fails to run checkstyle in hadoop-mapreduce-client
-1 ❌ mvnsite 0m 19s /patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app in the patch failed.
-1 ❌ mvnsite 0m 21s /patch-mvnsite-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 ❌ javadoc 0m 19s /patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdkUbuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.txt hadoop-mapreduce-client-app in the patch failed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04.
-1 ❌ javadoc 0m 19s /patch-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdkPrivateBuild-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.txt hadoop-mapreduce-client-app in the patch failed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09.
-1 ❌ spotbugs 0m 18s /patch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app in the patch failed.
-1 ❌ spotbugs 0m 20s /patch-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
-1 ❌ shadedclient 10m 42s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 8m 5s hadoop-mapreduce-client-core in the patch passed.
-1 ❌ unit 0m 22s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app in the patch failed.
-1 ❌ unit 0m 22s /patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt hadoop-mapreduce-client-jobclient in the patch failed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
158m 58s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/1/artifact/out/Dockerfile
GITHUB PR #8576
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle cc buflint bufcompat
uname Linux 009b9bdb5f95 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / a414f5d
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/1/testReport/
Max. process+thread count 1117 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran

Copy link
Copy Markdown
Contributor Author

java8 moved breaks things, doesn't it

@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 56s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ branch-3.4 Compile Tests _
+0 🆗 mvndep 11m 52s Maven dependency ordering for branch
+1 💚 mvninstall 46m 49s branch-3.4 passed
+1 💚 compile 2m 19s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 2m 33s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 27s branch-3.4 passed
+1 💚 mvnsite 2m 34s branch-3.4 passed
+1 💚 javadoc 2m 17s branch-3.4 passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 2m 6s branch-3.4 passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 47s branch-3.4 passed
+1 💚 shadedclient 39m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for patch
+1 💚 mvninstall 1m 24s the patch passed
+1 💚 compile 1m 42s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 cc 1m 42s the patch passed
+1 💚 javac 1m 42s the patch passed
+1 💚 compile 1m 33s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 cc 1m 33s the patch passed
+1 💚 javac 1m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 4s /results-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 67 unchanged - 5 fixed = 68 total (was 72)
+1 💚 mvnsite 1m 32s the patch passed
+1 💚 javadoc 1m 11s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 1m 4s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 3m 19s the patch passed
+1 💚 shadedclient 37m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 8m 7s hadoop-mapreduce-client-core in the patch passed.
+1 💚 unit 8m 20s hadoop-mapreduce-client-app in the patch passed.
+1 💚 unit 113m 29s hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
300m 21s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/2/artifact/out/Dockerfile
GITHUB PR #8576
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle cc buflint bufcompat
uname Linux 8bf9daaacc77 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.4 / 2cac213
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/2/testReport/
Max. process+thread count 1144 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8576/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran steveloughran merged commit 2bbcae5 into apache:branch-3.4 Jul 1, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants