HDFS-10256. Use GenericTestUtils.getTestDir method in tests for temporary directories #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinayakumarb
force-pushed
the
features/HDFS-10256
branch
3 times, most recently
from
d2949c4 to
df6467f
Compare
Member
There was a problem hiding this comment.
I found some other occurrences of /tmp/xxx, which is used as the root dir of FileContextTestHelper. Would you replace them? I'm thinking the following is fine:
return new FileContextTestHelper(GenericTestUtils.getTempPath("TestWebHdfsFileContextMainOperations"));
I'm okay if the replace is done in separate jira(s).
vinayakumarb
force-pushed
the
features/HDFS-10256
branch
3 times, most recently
from
18e77ba to
9c16dfc
Compare
vinayakumarb
force-pushed
the
features/HDFS-10256
branch
from
9c16dfc to
c4310ae
Compare
Member
|
Mostly looks good to me. Would you fix the checkstyle warnings? I'm +1 if that is addressed. |
vinayakumarb
force-pushed
the
features/HDFS-10256
branch
2 times, most recently
from
dc837e8 to
6b1edb6
Compare
vinayakumarb
force-pushed
the
features/HDFS-10256
branch
from
6b1edb6 to
df71ac1
Compare
Contributor
Author
|
Merged to trunk. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
More details in https://issues.apache.org/jira/browse/SAMZA-1143 Tests: ./gradlew clean check successful and all unit tests passed Author: Fred Ji <fji@linkedin.com> Reviewers: Jagadish <jagadish@apache.org> Closes apache#90 from fredji97/universalLocalizer
saxenapranav
pushed a commit
to saxenapranav/hadoop
that referenced
this pull request
Aug 11, 2023
Test fix for testReadBlob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the HDFS changes from HADOOP-12984