Update PandasExcelWriter to use pd.ExcelWriter#1078
Merged
skrawcz merged 2 commits intoapache:mainfrom Aug 6, 2024
Merged
Conversation
Contributor
|
Looking good. Mind adding a link to https://pandas.pydata.org/docs/reference/api/pandas.ExcelWriter.html on line 1484. |
Contributor
Author
|
Thanks, I added the link in the docstring for PandasExcelWriter. Otherwise, I think everything should be ready. There is an existing unit test under tests/plugins/test_pandas_extensions.py which tests the PandasExcelWriter and .save_data() method, so I don't think anything needs to be added here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to fix issue #946 -- PandasExcelWriter overwrites file
Changes
Changes to pandas_extensions.py in PandasExcelWriter to implement the pd.ExcelWriter and add appropriate keyword arguments to support this.
How I tested this
Locally via existing unit tests
Notes
Checklist
New functions are documented (with a description, list of inputs, and expected output)Placeholder code is flagged / future TODOs are captured in commentsProject documentation has been updated if adding/changing functionality.