Skip to content

Make sub-package verify scripts self-contained with full Apache checks#1610

Merged
skrawcz merged 1 commit into
mainfrom
stefan/verify-sub-packages-scripts
May 26, 2026
Merged

Make sub-package verify scripts self-contained with full Apache checks#1610
skrawcz merged 1 commit into
mainfrom
stefan/verify-sub-packages-scripts

Conversation

@skrawcz
Copy link
Copy Markdown
Contributor

@skrawcz skrawcz commented May 25, 2026

Changes

Updates scripts/verify-sub-packages/verify_*.sh to be fully self-contained release validation scripts. Each one now performs all 6 verification steps autonomously:

  1. Downloads artifacts from SVN (or accepts a local artifacts dir)
  2. Verifies GPG signatures
  3. Verifies SHA512 checksums
  4. Runs Apache RAT license check (using repo's .rat-excludes)
  5. Builds from source tarball with flit build --no-use-vcs
  6. Installs wheel in fresh uv venv and runs functional tests

Also adds scripts/verification-sub-packages.sh orchestrator.

Usage

Reviewer validates a single package:

scripts/verify-sub-packages/verify_sdk.sh 0.9.0 0
scripts/verify-sub-packages/verify_ui.sh 0.0.18 0
scripts/verify-sub-packages/verify_lsp.sh 0.2.0 0
scripts/verify-sub-packages/verify_contrib.sh 0.0.9 0

Or with pre-downloaded artifacts:

scripts/verify-sub-packages/verify_sdk.sh 0.9.0 0 ./path/to/artifacts/

How I tested

Ran all 4 scripts against the dry-run RC0 artifacts built from a fresh checkout:

=== apache-hamilton-sdk 0.9.0-RC0: ALL CHECKS PASSED ===
=== apache-hamilton-ui 0.0.18-RC0: ALL CHECKS PASSED ===
=== apache-hamilton-lsp 0.2.0-RC0: ALL CHECKS PASSED ===
=== apache-hamilton-contrib 0.0.9-RC0: ALL CHECKS PASSED ===

…functional checks

Each verify_*.sh script now:
- Downloads artifacts from SVN (or accepts local path)
- Verifies GPG signatures
- Verifies SHA512 checksums
- Runs Apache RAT with .rat-excludes
- Builds from source tarball
- Installs wheel and runs functional tests

Usage: scripts/verify-sub-packages/verify_sdk.sh 0.9.0 0 [artifacts_dir]

Also adds verification-sub-packages.sh orchestrator that runs all 4.
@elijahbenizzy elijahbenizzy requested review from elijahbenizzy and gmcdonald and removed request for gmcdonald May 26, 2026 02:03
@skrawcz skrawcz merged commit 21a4a96 into main May 26, 2026
@skrawcz skrawcz deleted the stefan/verify-sub-packages-scripts branch May 26, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants