Add frontend build step to UI release process#1612
Open
skrawcz wants to merge 1 commit into
Open
Conversation
The UI wheel must include compiled frontend assets (hamilton_ui/build/). This directory is gitignored and only exists after npm run build. - apache_release_helper.py: automatically runs npm install + npm run build and copies output to hamilton_ui/build/ before flit build for the UI package - verify-sub-packages.md: documents manual frontend build steps - verify_ui.sh: notes that source tarball build is backend-only; functional tests use the pre-compiled wheel from SVN
skrawcz
force-pushed
the
stefan/fix-ui-frontend-build
branch
from
8380900 to
86f5e79
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The UI wheel uploaded to SVN was missing compiled frontend assets (
hamilton_ui/build/). This directory is gitignored and only exists locally after runningnpm run build. A fresh clone (which is how we build release artifacts) doesn't have it, so the wheel was built without the frontend — causing HTTP 500 when serving/.Fix
scripts/apache_release_helper.py: When building theuipackage, automatically runsnpm install+npm run buildinui/frontend/and copies the output tohamilton_ui/build/beforeflit build.scripts/verify-sub-packages.md: Documents the manual frontend build steps for reviewers building from source.scripts/verify-sub-packages/verify_ui.sh: Clarifies that the 'build from source' step builds the backend only; functional tests use the pre-compiled wheel from SVN which includes the frontend.Impact
This requires re-cutting the UI RC (RC1) after merging. The other 3 sub-packages (SDK, LSP, Contrib) are unaffected.