Skip to content

fix arg name conflict positional module_name and named module_name#932

Merged
skrawcz merged 1 commit intomainfrom
fix/jupyter-v2-m-arg
Jun 1, 2024
Merged

fix arg name conflict positional module_name and named module_name#932
skrawcz merged 1 commit intomainfrom
fix/jupyter-v2-m-arg

Conversation

@zilto
Copy link
Contributor

@zilto zilto commented May 31, 2024

image

Changes

  • renamed the positional arg module_name to name. There should be no conflict since it's positional and therefore not "invoked by name"

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@zilto zilto added the bug Something isn't working label May 31, 2024
@zilto zilto requested a review from skrawcz May 31, 2024 23:50
@skrawcz skrawcz merged commit 22c0373 into main Jun 1, 2024
@skrawcz skrawcz deleted the fix/jupyter-v2-m-arg branch June 1, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments