HAWQ-1671. add compile support for orc formatter and wrapper#1399
HAWQ-1671. add compile support for orc formatter and wrapper#1399ion2014 wants to merge 2 commits intoapache:masterfrom
Conversation
ion2014
commented
Nov 4, 2018
ion2014
commented
contrib/hawq-hadoop/Makefile
Outdated
| ifdef MAVEN | ||
| ifeq ($(shell java -version 2>&1 | grep 1.7.0 > /dev/null; printf $$?),0) | ||
| $(MAVEN) package -DskipTests -Dhttps.protocols=TLSv1.2 | ||
| $(MAVEN) package -DskipTests -Dmaven.javadoc.skip=true -Dhttps.protocols=TLSv1.2 |
There was a problem hiding this comment.
this is because the javadoc added doclint in jdk8 which required stricter code format (which is not followed by the former code), so I temporarily disabled the javadoc.
There was a problem hiding this comment.
what's the reason of update hawq-hadoop/Makefile while this is a commit to add compile suppport for orc ?
There was a problem hiding this comment.
maybe I'll start a subtas for JDK8 support in another commit, thanks for your review!
contrib/orc/Makefile
Outdated
| # | ||
| MODULE_big = orc | ||
| OBJS = orc.o | ||
| OBJS = orc_wrapper/orc_wrapper.o orc_format/orc_format.o |
There was a problem hiding this comment.
cwrapper/cwrapper.o format/format.o
stanlyxiang
left a comment
stanlyxiang
left a comment
There was a problem hiding this comment.
please check all the comments and make sure the commit passed the jenkins and travis-ci check. The details link showed the details error message for your commit build.
contrib/hawq-hadoop/Makefile
Outdated
| ifdef MAVEN | ||
| ifeq ($(shell java -version 2>&1 | grep 1.7.0 > /dev/null; printf $$?),0) | ||
| $(MAVEN) package -DskipTests -Dhttps.protocols=TLSv1.2 | ||
| $(MAVEN) package -DskipTests -Dmaven.javadoc.skip=true -Dhttps.protocols=TLSv1.2 |
There was a problem hiding this comment.
what's the reason of update hawq-hadoop/Makefile while this is a commit to add compile suppport for orc ?
contrib/orc/orc_format/orc_format.c
Outdated
| @@ -0,0 +1 @@ | |||
| //this is a test file for compiling. No newline at end of file | |||
There was a problem hiding this comment.
if this file is useless, please do not add it to the commit.
if you use it as a placeholder, please add a more formal c source file with license header, otherwise your file won't pass apache-rat-check and no one will merge your commit to master.
There was a problem hiding this comment.
Thanks for the information, I'll add the license header on the amending commits.
ranger-plugin/integration/pom.xml
Outdated
| <source>1.7</source> | ||
| <target>1.7</target> | ||
| <source>1.8</source> | ||
| <target>1.8</target> |
There was a problem hiding this comment.
what's the reason to update maven-compiler-plugin version for range-plugin ?
ion2014
force-pushed
the
plug_orc
branch
3 times, most recently
from
0c3949f to
c6b0d89
Compare
ion2014
changed the title
ion2014
changed the title
ion2014
force-pushed
the
plug_orc
branch
3 times, most recently
from
240f07d to
b094599
Compare
Changed Makefile in contrib/orc Add folder format and cwrapper for split compilation Add dummy code for testing the Makefile
|
+1 |
|
+1 LGTM, Thanks. |
add cwrapper.cpp to generate interface code for C/C++ link. changed Makefile to support cpp compiling.
4 participants
