Skip to content

HBASE-27943 Rework kuttl image as a yetus precommit base#5

Merged
ndimiduk merged 1 commit intoapache:mainfrom
ndimiduk:27943-kuttl-as-yetus-precommit
Dec 18, 2023
Merged

HBASE-27943 Rework kuttl image as a yetus precommit base#5
ndimiduk merged 1 commit intoapache:mainfrom
ndimiduk:27943-kuttl-as-yetus-precommit

Conversation

@ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jun 21, 2023

Here's a draft PR that demonstrates the direction this plan leads. Maybe we can bring the image build back to Apache Jenkins because there is some action on INFRA-24704. I'm not sure whether I prefer that vs. using GitHub actions.

Edit:

This change diverts from the original inspiration from Yetus. Rather than build and publish an image, we re-build the test image every time. This makes for a longer build cycle in CI, but lets me punt on the question of how HBase project wants to handle publishing container images. The kuttl image is now based on the Yetus pre-commit image, so all testing tools are available everywhere. Jenkins PR build is updated accordingly, and these changes are used to test this PR. I think the links to individual check output results from the PR comment are still broken. Additional notes:

  • build_docker_image script is copied mostly verbatim from Yetus.
  • kuttl.sh is a Yetus precommit plugin that add support for running kuttl and will be used by and refined in subsequent commits.
  • test.bats adds some basic test coverage of the kuttl image, makes sure that the various utilities run on the platform architecture.

@ndimiduk ndimiduk force-pushed the 27943-kuttl-as-yetus-precommit branch 3 times, most recently from 111dbb1 to ce5393b Compare September 26, 2023 08:19
@ndimiduk ndimiduk force-pushed the 27943-kuttl-as-yetus-precommit branch 2 times, most recently from d8f601c to 8dc3c13 Compare October 23, 2023 12:58
@ndimiduk
Copy link
Member Author

@aw-was-here @busbey any idea why the docker image that i build in one stage is not visible to the next? See https://ci-hbase.apache.org/blue/organizations/jenkins/hbase-kustomize-github-pr/detail/PR-5/8/pipeline

@aw-was-here
Copy link

@aw-was-here @busbey any idea why the docker image that i build in one stage is not visible to the next?

DOCKER_ARGS+=('--pull' 'always') will ignore the local cache IIRC.

@ndimiduk
Copy link
Member Author

ndimiduk commented Nov 8, 2023

Thank you @aw-was-here !

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

Use yetus precommit as the base image for the kuttl image, that way the whole
thing can be easily used in CI as well as for local testing.
@ndimiduk ndimiduk force-pushed the 27943-kuttl-as-yetus-precommit branch from f54044e to daa11d3 Compare December 16, 2023 15:52
@ndimiduk ndimiduk marked this pull request as ready for review December 16, 2023 15:52
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ main Compile Tests _
_ Patch Compile Tests _
+1 💚 codespell 0m 0s No new issues.
+1 💚 detsecrets 0m 2s No new issues.
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 hadolint 0m 0s No new issues.
+1 💚 markdownlint 0m 2s No new issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shelldocs 0m 0s No new issues.
_ Other Tests _
+1 💚 asflicense 0m 1s The patch does not generate ASF License warnings.
0m 9s
Subsystem Report/Notes
GITHUB PR #5
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs hadolint markdownlint
uname Linux 8777e688f4bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool nobuild
Personality /workdir/src/.yetus/personality.sh
git revision main / daa11d3
modules C: . U: .
versions git=2.25.1 codespell=2.2.1 detsecrets=1.2.0 markdownlint=0.31.1 shellcheck=0.8.0
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Copy link

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a jenkins or docker expert but anyway, since the pre commit build is OK, let's try it and move on!

@ndimiduk ndimiduk merged commit dc94048 into apache:main Dec 18, 2023
@ndimiduk ndimiduk deleted the 27943-kuttl-as-yetus-precommit branch December 18, 2023 07:51
@ndimiduk
Copy link
Member Author

Thanks @Apache9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants