HBASE-27943 Rework kuttl image as a yetus precommit base#5
Merged
ndimiduk merged 1 commit intoapache:mainfrom Dec 18, 2023
Merged
Conversation
aw-was-here
reviewed
Jun 24, 2023
aw-was-here
reviewed
Jun 24, 2023
111dbb1 to
ce5393b
Compare
d8f601c to
8dc3c13
Compare
Member
Author
|
@aw-was-here @busbey any idea why the docker image that i build in one stage is not visible to the next? See https://ci-hbase.apache.org/blue/organizations/jenkins/hbase-kustomize-github-pr/detail/PR-5/8/pipeline |
|
Member
Author
|
Thank you @aw-was-here ! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Use yetus precommit as the base image for the kuttl image, that way the whole thing can be easily used in CI as well as for local testing.
f54044e to
daa11d3
Compare
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Dec 17, 2023
Apache9
left a comment
There was a problem hiding this comment.
I'm not a jenkins or docker expert but anyway, since the pre commit build is OK, let's try it and move on!
Member
Author
|
Thanks @Apache9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a draft PR that demonstrates the direction this plan leads. Maybe we can bring the image build back to Apache Jenkins because there is some action on INFRA-24704. I'm not sure whether I prefer that vs. using GitHub actions.
Edit:
This change diverts from the original inspiration from Yetus. Rather than build and publish an image, we re-build the test image every time. This makes for a longer build cycle in CI, but lets me punt on the question of how HBase project wants to handle publishing container images. The
kuttlimage is now based on the Yetus pre-commit image, so all testing tools are available everywhere. Jenkins PR build is updated accordingly, and these changes are used to test this PR. I think the links to individual check output results from the PR comment are still broken. Additional notes:build_docker_imagescript is copied mostly verbatim from Yetus.kuttl.shis a Yetus precommit plugin that add support for running kuttl and will be used by and refined in subsequent commits.test.batsadds some basic test coverage of the kuttl image, makes sure that the various utilities run on the platform architecture.