HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system#5
Merged
bharathv merged 2 commits intoapache:masterfrom Jun 15, 2020
Merged
HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system#5bharathv merged 2 commits intoapache:masterfrom
bharathv merged 2 commits intoapache:masterfrom
Conversation
phrocker
changed the title
Contributor
Author
|
I remembered that I didn't add anything to BUILDING.md. Will do that now to make it clear. may also add a build script too if that's useful. |
bharathv
approved these changes
Jun 12, 2020
Contributor
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Nice.. tried it out locally.. compiles good. One minor comment and I can commit.
| BIN_DIR=$(pushd `dirname "$0"` 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null) | ||
| BASE_DIR=$(pushd "${BIN_DIR}/../" 2>&1 > /dev/null && pwd && popd 2>&1 > /dev/null) | ||
|
|
||
| ${BIN_DIR}/copy-protobuf.sh |
Contributor
There was a problem hiding this comment.
git rm these files? I don't think these are needed anymore
Contributor
Author
There was a problem hiding this comment.
ah yeah i think I removed them in the other draft PR I have open, but since they are no longer referenced here I should remove them. thanks for pointing this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HBASE-24540: Leverage DOWNLOAD_DEPENDENCIES in docker build system