Skip to content

Conversation

@haridsv
Copy link
Contributor

@haridsv haridsv commented Sep 5, 2025

Addendum to PR #7256

Also includes the following additional changes done in PR #7274 from branch-2:

  • Reverted the change admin test, adding back the dedicated driver and renaming the ruby test file.
  • Removed BaseTestShell as it is no longer needed after serving the requirement of admin test via its own driver
  • The base setUp() method now uses a single node cluster and only admin and RS group tests override it to 3 nodes.

…pache#7276

Also includes the following additional changes done in PR apache#7274 from branch-2:
- Reverted the change admin test, adding back the dedicated driver and renaming the ruby test file.
- Removed BaseTestShell as it is no longer needed after serving the requirement of admin test via its own driver
- The base setUp() method now uses a single node cluster and only admin and RS group tests override it to 3 nodes.
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 25s master passed
+1 💚 compile 0m 16s master passed
+1 💚 javadoc 0m 12s master passed
+1 💚 shadedjars 6m 15s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 12s the patch passed
+1 💚 compile 0m 17s the patch passed
+1 💚 javac 0m 17s the patch passed
+1 💚 javadoc 0m 10s the patch passed
+1 💚 shadedjars 6m 13s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 6m 46s hbase-shell in the patch passed.
28m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7277/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7277
Optional Tests javac javadoc unit compile shadedjars
uname Linux 2b10cd531713 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9b18070
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7277/1/testReport/
Max. process+thread count 1672 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7277/1/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 58s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 24s master passed
+1 💚 compile 0m 19s master passed
+1 💚 checkstyle 0m 8s master passed
+1 💚 spotbugs 0m 0s master passed
+1 💚 spotless 0m 50s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 compile 0m 18s the patch passed
+1 💚 javac 0m 18s hbase-shell generated 0 new + 2 unchanged - 5 fixed = 2 total (was 7)
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 7s the patch passed
+1 💚 rubocop 0m 15s No new issues.
+1 💚 spotbugs 0m 0s the patch passed
+1 💚 hadoopcheck 12m 11s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
30m 41s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7277/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7277
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless rubocop
uname Linux 6b74986ac03e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9b18070
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7277/1/console
versions git=2.34.1 maven=3.9.8 rubocop=1.37.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani changed the title HBASE-29558: Addendum to fix PR validation warnings on the lines of #7276 HBASE-29558: Addendum to fix checkstyle warnings Sep 5, 2025
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit 494cbe4 into apache:master Sep 5, 2025
1 check passed
virajjasani pushed a commit that referenced this pull request Sep 5, 2025
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Sep 5, 2025
Signed-off-by: Viraj Jasani <vjasani@apache.org>
virajjasani pushed a commit that referenced this pull request Sep 5, 2025
Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants