Skip to content

Catch exception in group commit #1440

@zhangmeng916

Description

@zhangmeng916

Describe the bug

In group commit commit function, the return value is true or false, denoting whether the group commit succeed or not. However, in the read data path, if there is an exception such as zkclient is closed, etc., an exception will still be thrown in group commit. This is inconsistent with group commit java doc, and also different from normal update zk operation, which catches all exception.

To Reproduce

Zkclient closed will throw an exception in group commit.

Expected behavior

Group commit catches all exceptions and return false.

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions