Skip to content

Fix testInstancesStoppable_zoneBased #879

@NealSun96

Description

@NealSun96

The changes merged in #858 broke testInstancesStoppable_zoneBased. The test didn't create external views at all, which will encounter exceptions with the new logic.
The logic added wasn't supposed to break the tests because the logic is to perform null checks before an if condition that utilizes maps. However, the tests were passing because in the "and" if condition, it failed at isPartitionMap.containsKey(instanceName) without accessing the second part of the "and" condition. Therefore, even though the second part could cause an null pointer failure, it was never an issue. The fix is to reorder the logic such that the conditions are performed separately with null checks right before each map access.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions