Add Abnormal States Resolver interface and configuration item.#1028
Merged
jiajunwang merged 3 commits intoapache:abnormalResolverfrom May 28, 2020
Merged
Add Abnormal States Resolver interface and configuration item.#1028jiajunwang merged 3 commits intoapache:abnormalResolverfrom
jiajunwang merged 3 commits intoapache:abnormalResolverfrom
Conversation
added 2 commits
May 26, 2020 12:45
The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example,
- double masters
- application data out of sync
The interface shall be implemented according to the requirement.
The resolver is applied in the rebalance process according to the corresponding cluster config item. For example,
"ABNORMAL_STATES_RESOLVER_MAP" : {
"MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler"
}
The default behavior without any configuration is not doing any recovery work.
junkaixue
reviewed
May 27, 2020
...core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to be merged, approved by @dasahcc |
Contributor
Author
|
Will checkin to a separate branch for reviewing the later PRs. |
This was referenced May 28, 2020
jiajunwang
added a commit
that referenced
this pull request
Jun 9, 2020
The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example,
- double masters
- application data out of sync
The interface shall be implemented according to the requirement.
The resolver is applied in the rebalance process according to the corresponding cluster config item. For example,
"ABNORMAL_STATES_RESOLVER_MAP" : {
"MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler"
}
The default behavior without any configuration is not doing any recovery work.
jiajunwang
added a commit
that referenced
this pull request
Jun 15, 2020
The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example,
- double masters
- application data out of sync
The interface shall be implemented according to the requirement.
The resolver is applied in the rebalance process according to the corresponding cluster config item. For example,
"ABNORMAL_STATES_RESOLVER_MAP" : {
"MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler"
}
The default behavior without any configuration is not doing any recovery work.
jiajunwang
added a commit
that referenced
this pull request
Jun 15, 2020
The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example,
- double masters
- application data out of sync
The interface shall be implemented according to the requirement.
The resolver is applied in the rebalance process according to the corresponding cluster config item. For example,
"ABNORMAL_STATES_RESOLVER_MAP" : {
"MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler"
}
The default behavior without any configuration is not doing any recovery work.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
…e#1028) The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example, - double masters - application data out of sync The interface shall be implemented according to the requirement. The resolver is applied in the rebalance process according to the corresponding cluster config item. For example, "ABNORMAL_STATES_RESOLVER_MAP" : { "MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler" } The default behavior without any configuration is not doing any recovery work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#1027
Description
The Abnormal States Resolver defines a generic interface to find and recover if the partition has any abnormal current states. For example,
The interface shall be implemented according to the requirement.
The resolver is applied in the rebalance process according to the corresponding cluster config item. For example,
"ABNORMAL_STATES_RESOLVER_MAP" : {
"MASTERSLAVE" : "org.apache.helix.api.rebalancer.constraint.MasterSlaveAbnormalStateReslovler"
}
The default behavior without any configuration is not doing any recovery work.
Tests
TestAbnormalStatesResolver
TestClusterConfig.testAbnormalStatesResolverConfig()
helix-rest, All passed
helix-core,
[ERROR] Failures:
[ERROR] TestRebalanceRunningTask.testFixedTargetTaskAndEnabledRebalanceAndNodeAdded:330 expected: but was:
[ERROR] TestTaskThrottling.testTaskThrottle:98 expected:<10> but was:<0>
[ERROR] TestWorkflowTimeout.testWorkflowTimeoutWhenWorkflowCompleted:116 expected: but was:
[INFO]
[ERROR] Tests run: 1148, Failures: 3, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
Rerun
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.296 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 56.539 s
[INFO] Finished at: 2020-05-27T09:53:49-07:00
[INFO] ------------------------------------------------------------------------
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)