Move serializers to zookeeper-api#1085
Merged
narendly merged 1 commit intoapache:masterfrom Jun 15, 2020
Merged
Conversation
junkaixue
approved these changes
Jun 15, 2020
Contributor
Author
|
This PR is ready to be merged, approved by @dasahcc Move serializers to zookeeper-api (#1085) Some serializer implementations (Chained, ByteArray) were never moved to zookeeper-api. This commit moves them out of helix-core and into zookeeper-api. Note that this might cause older implementations of Helix applications to no longer build. Since this is an API-level change that simply moves the classes, the user can simply update the package path in the import statements and can make it build again. |
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Some serializer implementations (Chained, ByteArray) were never moved to zookeeper-api. This commit moves them out of helix-core and into zookeeper-api. Note that this might cause older implementations of Helix applications to no longer build. Since this is an API-level change that simply moves the classes, the user can simply update the package path in the import statements and can make it build again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #631
Description
Some serializer implementations were never moved to zookeeper-api. This commit moves them out of helix-core and into zookeeper-api.
Tests
No test needed.
[ERROR] Failures:
[ERROR] TestZKCallback.testInvocation:188
[ERROR] TestEnableCompression.testEnableCompressionResource:117 expected: but was:
[ERROR] TestControllerLeadershipChange.testMissingTopStateDurationMonitoring:262 expected: but was:
[ERROR] TestClusterInMaintenanceModeWhenReachingMaxPartition.testDisableCluster:119 expected: but was:
[INFO]
[ERROR] Tests run: 1139, Failures: 4, Errors: 0, Skipped: 0
Run separately:
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 39.199 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)