Enhance flaky test TestRemoveUserCbHandlerOnPathRemoval#1104
Merged
jiajunwang merged 2 commits intoapache:watcherfrom Jun 19, 2020
Merged
Enhance flaky test TestRemoveUserCbHandlerOnPathRemoval#1104jiajunwang merged 2 commits intoapache:watcherfrom
jiajunwang merged 2 commits intoapache:watcherfrom
Conversation
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Addres the assertion in this diff.
jiajunwang
reviewed
Jun 18, 2020
helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to be merged, approved by @jiajunwang
|
kaisun2000
added a commit
to kaisun2000/helix
that referenced
this pull request
Jun 23, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff. Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
jiajunwang
pushed a commit
that referenced
this pull request
Jun 24, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff. Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
TestRemoveUserCbHandlerOnPathRemoval has a flaky assert. Address the assertion in this diff. Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1102
TestRemoveUserCbHandlerOnPathRemoval has a flaky test
Description
Assert .assertEquals(watchPaths.get("existWatches").size(), 2, "Should have 2 exist-watches: CURRENTSTATE/{oldSessionId} and CURRENTSTATE/{oldSessionId}/TestDB0");is flaky.
Tests
(List the names of added unit/integration tests)
This test case pass. This pull only touch test case logic.
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)