Closed
Conversation
huizhilu
commented
Jun 23, 2020
| return true; | ||
| // Because current state equals pending message's toState, pending message is ignored | ||
| // and ST messages are sent to localhost_0, messages number >= 1 | ||
| return !allMsgs.isEmpty() && allMsgs.get(0).getToState().equals("MASTER") && allMsgs.get(0) |
Contributor
Author
There was a problem hiding this comment.
This is the change to pass the test, allowing messages size >= 1
| return false; | ||
| } | ||
| // Should verify messages on each live instance are not purged. | ||
| isMessagePurged = isMessagePurged || messages.isEmpty(); |
Contributor
Author
There was a problem hiding this comment.
Change 1: verify messages on each live instance are not purged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1116
Description
Unit test testMsgTriggeredRebalance() consistently fails, because we allow ignoring pending messages and sending ST messages when current state equals pending msg's to state. We should change the test condition a bit to allow messages number >= 1.
Two changes for the test:
This PR also formats the file
TestRebalancePipeline.javaTests
Changed
testMsgTriggeredRebalanceOnly fix the test so just run and pass the single test.
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)