Skip to content

Shutdown the TaskStateModelFactory threads created in the tests.#1140

Merged
jiajunwang merged 2 commits intoapache:masterfrom
jiajunwang:master
Jul 7, 2020
Merged

Shutdown the TaskStateModelFactory threads created in the tests.#1140
jiajunwang merged 2 commits intoapache:masterfrom
jiajunwang:master

Conversation

@jiajunwang
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#1139

Description

  • Here are some details about my PR, including screenshots of any UI changes:

The TaskStateModelFactory initialization creates a thread pool. The expectation is that the application code closes the thread pool and the threads when the participant instance is shutting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these thread pools leak thousands of threads.
This PR adds cleanup logic to shutdown thread pools that are created for the participant instances. Note that there is still thread leakage when the participants are created separately instead of using the general methods.

Tests

  • The following tests are written for this issue:

No new tests.

  • The following is the result of the "mvn test" command on the appropriate module:

This PR allows my MacBook to finish the tests. There are still some failures but it is the first time I saw the full test suite finishes without OutOfMemory! For sure we can fix those failures next.

The following result is what I got from the Linux desktop.

helix-core
[ERROR] Failures:
[ERROR] TestTaskSchedulingTwoCurrentStates.testTargetedTaskTwoCurrentStates:150 expected: but was:
[INFO]
[ERROR] Tests run: 1151, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:17 h
[INFO] Finished at: 2020-07-04T13:56:23-07:00
[INFO] ------------------------------------------------------------------------
rerun:
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.791 s - in org.apache.helix.integration.task.TestTaskSchedulingTwoCurrentStates
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25.598 s
[INFO] Finished at: 2020-07-04T15:40:37-07:00
[INFO] ------------------------------------------------------------------------

helix-rest

[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.031 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.914 s
[INFO] Finished at: 2020-07-04T15:55:23-07:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

The TaskStateModelFactory initialization creates threadpool. The expectation is that the application code closes the threadpool and the threads when the participant instance is shuting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these threadpools leak thousands of the threads.
This PR adds cleanup logic to shutdown threadpools that are created for the partcipant instances. Note that there are still threads leakage when the participants are created separately instead of using the general methods.
@jiajunwang
Copy link
Contributor Author

This PR is ready to be merged, approved by @narendly

@jiajunwang jiajunwang merged commit 3fc8708 into apache:master Jul 7, 2020
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
…che#1140)

The TaskStateModelFactory initialization creates a thread pool. The expectation is that the application code closes the thread pool and the threads when the participant instance is shutting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these thread pools leak thousands of threads.
This PR adds cleanup logic to shutdown thread pools that are created for the participant instances. Note that there is still thread leakage when the participants are created separately instead of using the general methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants