Shutdown the TaskStateModelFactory threads created in the tests.#1140
Merged
jiajunwang merged 2 commits intoapache:masterfrom Jul 7, 2020
Merged
Shutdown the TaskStateModelFactory threads created in the tests.#1140jiajunwang merged 2 commits intoapache:masterfrom
jiajunwang merged 2 commits intoapache:masterfrom
Conversation
The TaskStateModelFactory initialization creates threadpool. The expectation is that the application code closes the threadpool and the threads when the participant instance is shuting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these threadpools leak thousands of the threads. This PR adds cleanup logic to shutdown threadpools that are created for the partcipant instances. Note that there are still threads leakage when the participants are created separately instead of using the general methods.
narendly
reviewed
Jul 5, 2020
helix-core/src/test/java/org/apache/helix/task/TaskSynchronizedTestBase.java
Outdated
Show resolved
Hide resolved
narendly
approved these changes
Jul 5, 2020
Contributor
Author
|
This PR is ready to be merged, approved by @narendly |
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
…che#1140) The TaskStateModelFactory initialization creates a thread pool. The expectation is that the application code closes the thread pool and the threads when the participant instance is shutting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these thread pools leak thousands of threads. This PR adds cleanup logic to shutdown thread pools that are created for the participant instances. Note that there is still thread leakage when the participants are created separately instead of using the general methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#1139
Description
The TaskStateModelFactory initialization creates a thread pool. The expectation is that the application code closes the thread pool and the threads when the participant instance is shutting down. In most cases, this means the JVM is going to be shutdown. So this operation is not a must. However, in the test cases, these thread pools leak thousands of threads.
This PR adds cleanup logic to shutdown thread pools that are created for the participant instances. Note that there is still thread leakage when the participants are created separately instead of using the general methods.
Tests
No new tests.
This PR allows my MacBook to finish the tests. There are still some failures but it is the first time I saw the full test suite finishes without OutOfMemory! For sure we can fix those failures next.
The following result is what I got from the Linux desktop.
helix-core
[ERROR] Failures:
[ERROR] TestTaskSchedulingTwoCurrentStates.testTargetedTaskTwoCurrentStates:150 expected: but was:
[INFO]
[ERROR] Tests run: 1151, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:17 h
[INFO] Finished at: 2020-07-04T13:56:23-07:00
[INFO] ------------------------------------------------------------------------
rerun:
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.791 s - in org.apache.helix.integration.task.TestTaskSchedulingTwoCurrentStates
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25.598 s
[INFO] Finished at: 2020-07-04T15:40:37-07:00
[INFO] ------------------------------------------------------------------------
helix-rest
[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.031 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 163, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 52.914 s
[INFO] Finished at: 2020-07-04T15:55:23-07:00
[INFO] ------------------------------------------------------------------------
Commits
Documentation (Optional)
(Link the GitHub wiki you added)
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)