Remove legacy duplicate metric classes in helix-core#1147
Merged
narendly merged 2 commits intoapache:masterfrom Jul 15, 2020
Merged
Remove legacy duplicate metric classes in helix-core#1147narendly merged 2 commits intoapache:masterfrom
narendly merged 2 commits intoapache:masterfrom
Conversation
As part of ZooKeeper API separation initiative, most metric-related classes were moved to metrics-common module. However, there were some that were left in helix-core for backward-compatibility purposes, but these were causing class conflicts at runtime. This change removes such classes.
Contributor
Author
|
@pkuwm It seems that you submitted a change to DynamicMBeanProvider.java recently. Could you give this a quick look and make sure your change wasn't overriden? |
jiajunwang
reviewed
Jul 14, 2020
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
Outdated
Show resolved
Hide resolved
jiajunwang
approved these changes
Jul 14, 2020
asfgit
pushed a commit
that referenced
this pull request
Jul 15, 2020
As part of ZooKeeper API separation initiative, most metric-related classes were moved to metrics-common module. However, there were some that were left in helix-core for backward-compatibility purposes, but these were causing class conflicts at runtime. This change removes such classes.
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
As part of ZooKeeper API separation initiative, most metric-related classes were moved to metrics-common module. However, there were some that were left in helix-core for backward-compatibility purposes, but these were causing class conflicts at runtime. This change removes such classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1146
Description
As part of ZooKeeper API separation initiative, most metric-related classes were moved to metrics-common module. However, there were some that were left in helix-core for backward-compatibility purposes, but these were causing class conflicts at runtime. This change removes such classes.
Tests
No tests written.
zookeeper-api:
helix-core:
Failures were ran individually:
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)