Add latency metric support for customized view aggregation#1187
Merged
huizhilu merged 8 commits intoapache:masterfrom Aug 14, 2020
Merged
Add latency metric support for customized view aggregation#1187huizhilu merged 8 commits intoapache:masterfrom
huizhilu merged 8 commits intoapache:masterfrom
Conversation
huizhilu
reviewed
Aug 2, 2020
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
jiajunwang
reviewed
Aug 5, 2020
...x-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateComputationStage.java
Outdated
Show resolved
Hide resolved
...x-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateComputationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
zhangmeng916
reviewed
Aug 5, 2020
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/controller/stages/TestCustomizedViewStage.java
Outdated
Show resolved
Hide resolved
zhangmeng916
reviewed
Aug 7, 2020
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/controller/stages/TestCustomizedViewStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
jiajunwang
reviewed
Aug 11, 2020
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/helix/controller/dataproviders/ResourceControllerDataProvider.java
Outdated
Show resolved
Hide resolved
1813eec to
db48ed9
Compare
jiajunwang
reviewed
Aug 13, 2020
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Outdated
Show resolved
Hide resolved
jiajunwang
reviewed
Aug 14, 2020
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/CustomizedViewMonitor.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedStateOutput.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/controller/stages/CustomizedViewAggregationStage.java
Show resolved
Hide resolved
Contributor
Author
|
This PR is ready to merge, approved by @jiajunwang |
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Add support for latency metric reporting between the time when user updates customized state for a partition using CustomizedStateProvider, and the time this change shows up in aggregated customized view and written to zk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1214
Description
This PR adds support for latency metric reporting between the time when user updates customized state for a partition using CustomizedStateProvider, and the time this change shows up in aggregated customized view and written to zk. With that, we can 1. compare this latency with other pipeline latencies, so we know if this newly added feature saturate our controller or not 2. get an understanding of the pipeline performance 3. better monitor this feature and diagnose any problems in the future
Added:
Modified:
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1168, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 h
[INFO] Finished at: 2020-08-13T19:47:48-07:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)