Skip to content

Add latency metric support for customized view aggregation#1187

Merged
huizhilu merged 8 commits intoapache:masterfrom
mgao0:metrics
Aug 14, 2020
Merged

Add latency metric support for customized view aggregation#1187
huizhilu merged 8 commits intoapache:masterfrom
mgao0:metrics

Conversation

@mgao0
Copy link
Contributor

@mgao0 mgao0 commented Jul 29, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #1214

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR adds support for latency metric reporting between the time when user updates customized state for a partition using CustomizedStateProvider, and the time this change shows up in aggregated customized view and written to zk. With that, we can 1. compare this latency with other pipeline latencies, so we know if this newly added feature saturate our controller or not 2. get an understanding of the pipeline performance 3. better monitor this feature and diagnose any problems in the future

  • The following tests are written for this issue:

Added:

  1. TestCustomizedViewMonitor
  2. TestCustomizedViewStage -> testLatencyMetricReporting

Modified:

  1. TestCustomizedStateUpdate
  2. TestCustomizedViewAggregation
  • The following is the result of the "mvn test" command on the appropriate module:

[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 1168, Failures: 0, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:13 h
[INFO] Finished at: 2020-08-13T19:47:48-07:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@mgao0 mgao0 changed the title [WIP] Add latency metrics for customized view aggregation Add latency metrics for customized view aggregation Aug 4, 2020
@mgao0 mgao0 changed the title Add latency metrics for customized view aggregation Add latency metric for customized view aggregation Aug 4, 2020
@mgao0 mgao0 changed the title Add latency metric for customized view aggregation Add latency metric support for customized view aggregation Aug 4, 2020
@mgao0 mgao0 force-pushed the metrics branch 2 times, most recently from 1813eec to db48ed9 Compare August 12, 2020 19:00
Copy link
Contributor

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgao0
Copy link
Contributor Author

mgao0 commented Aug 14, 2020

This PR is ready to merge, approved by @jiajunwang
Final commit message:
Add latency metric support for customized view aggregation

@huizhilu huizhilu merged commit 918039b into apache:master Aug 14, 2020
@mgao0 mgao0 deleted the metrics branch August 16, 2020 00:37
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
Add support for latency metric reporting between the time when user updates customized state for a partition using CustomizedStateProvider, and the time this change shows up in aggregated customized view and written to zk.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add latency metric support for customized view aggregation

4 participants