Skip to content

Comments

Add PR/Issue template and actions to validate PR status.#1223

Merged
jiajunwang merged 4 commits intoapache:masterfrom
jiajunwang:master
Aug 6, 2020
Merged

Add PR/Issue template and actions to validate PR status.#1223
jiajunwang merged 4 commits intoapache:masterfrom
jiajunwang:master

Conversation

@jiajunwang
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Resolves #1222

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Add 2 issue templates and one PR template to the Helix project.
Also, add Github actions based on the PR template so as to automatically update the PR status based on any PR updates.

Tests

  • The following tests are written for this issue:

Tested in my forked repo, jiajunwang#8

  • The following is the result of the "mvn test" command on the appropriate module:

NA

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@narendly narendly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jiajunwang
Copy link
Contributor Author

This PR is ready to be merged.

@jiajunwang jiajunwang merged commit 4aa7113 into apache:master Aug 6, 2020
junkaixue pushed a commit to junkaixue/helix that referenced this pull request Aug 11, 2020
Add 2 issue templates and one PR template to the Helix project.
Also, add Github actions based on the PR template so as to automatically update the PR status based on any PR updates.
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
Add 2 issue templates and one PR template to the Helix project.
Also, add Github actions based on the PR template so as to automatically update the PR status based on any PR updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need PR issue templates

2 participants