Add totalMessageReceivedCounter and decrepcate old totalMessageReceived#1251
Merged
junkaixue merged 2 commits intoapache:masterfrom Aug 12, 2020
Merged
Add totalMessageReceivedCounter and decrepcate old totalMessageReceived#1251junkaixue merged 2 commits intoapache:masterfrom
junkaixue merged 2 commits intoapache:masterfrom
Conversation
Currently we should have counter type for totalMessageReceived but did not make it correct. To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
narendly
reviewed
Aug 12, 2020
helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
Outdated
Show resolved
Hide resolved
narendly
approved these changes
Aug 12, 2020
Contributor
Author
|
This PR is ready to be merged. |
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
…ed (apache#1251) Currently we should have counter type for totalMessageReceived but did not make it correct. To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
fixes #1249
Description
Currently we should have counter type for totalMessageReceived but did not make it correct.
To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
Tests
The following tests are written for this issue:
The following is the result of the "mvn test" command on the appropriate module:
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestWagedRebalance.testChangeIdealState:303->validate:646 expected: but was:
[INFO]
[ERROR] Tests run: 1163, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:22 h
[INFO] Finished at: 2020-08-11T14:56:32-07:00
[INFO] Final Memory: 32M/1106M
[INFO] ------------------------------------------------------------------------
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.931 s - in org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 min
[INFO] Finished at: 2020-08-11T15:35:08-07:00
[INFO] Final Memory: 32M/1113M
[INFO] ------------------------------------------------------------------------
Documentation (Optional)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)