Skip to content

Add totalMessageReceivedCounter and decrepcate old totalMessageReceived#1251

Merged
junkaixue merged 2 commits intoapache:masterfrom
junkaixue:master
Aug 12, 2020
Merged

Add totalMessageReceivedCounter and decrepcate old totalMessageReceived#1251
junkaixue merged 2 commits intoapache:masterfrom
junkaixue:master

Conversation

@junkaixue
Copy link
Contributor

@junkaixue junkaixue commented Aug 11, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

fixes #1249

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Currently we should have counter type for totalMessageReceived but did not make it correct.
To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.

Tests

  • The following tests are written for this issue:

  • The following is the result of the "mvn test" command on the appropriate module:
    [INFO] Results:
    [INFO]
    [ERROR] Failures:
    [ERROR] TestWagedRebalance.testChangeIdealState:303->validate:646 expected: but was:
    [INFO]
    [ERROR] Tests run: 1163, Failures: 1, Errors: 0, Skipped: 0
    [INFO]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 01:22 h
    [INFO] Finished at: 2020-08-11T14:56:32-07:00
    [INFO] Final Memory: 32M/1106M
    [INFO] ------------------------------------------------------------------------

[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.931 s - in org.apache.helix.integration.rebalancer.WagedRebalancer.TestWagedRebalance
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:05 min
[INFO] Finished at: 2020-08-11T15:35:08-07:00
[INFO] Final Memory: 32M/1113M
[INFO] ------------------------------------------------------------------------

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Currently we should have counter type for totalMessageReceived but did not make it correct.
To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
@junkaixue
Copy link
Contributor Author

This PR is ready to be merged.

@junkaixue junkaixue merged commit f737b83 into apache:master Aug 12, 2020
huizhilu pushed a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
…ed (apache#1251)

Currently we should have counter type for totalMessageReceived but did not make it correct.
To fix this, we should have the a new counter metrics instead of directly changing the metrics for smooth migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename totalReceivedMessage to counter type clearly

2 participants