change default monitor window length from 1 hour to 1 min#1261
Merged
junkaixue merged 1 commit intoapache:masterfrom Aug 12, 2020
Merged
change default monitor window length from 1 hour to 1 min#1261junkaixue merged 1 commit intoapache:masterfrom
junkaixue merged 1 commit intoapache:masterfrom
Conversation
narendly
approved these changes
Aug 12, 2020
Contributor
Author
|
This PR is ready to merge, approved by @narendly |
huizhilu
pushed a commit
to huizhilu/helix
that referenced
this pull request
Aug 16, 2020
Change default monitor window length from 1 hour to 1 min
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixed #1259
Description
Helix default monitor window length was set as 1 hour for histogram metrics. The long time window leads to a high memory usage during runtime. This PR changes the default length from 1 hour to 1 min in order to reduce memory usage.
Tests
helix-core:
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestWagedRebalance.testChangeIdealState:303->validate:646 expected: but was:
[INFO]
[ERROR] Tests run: 1163, Failures: 1, Errors: 0, Skipped: 1
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:15 h
[INFO] Finished at: 2020-08-12T15:13:28-07:00
helix-rest
[INFO] Tests run: 165, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.512 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 165, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 34.307 s
[INFO] Finished at: 2020-08-12T15:29:08-07:00
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)