Fix routingDataSourceType not configured in helix rest#1309
Merged
huizhilu merged 1 commit intoapache:masterfrom Aug 24, 2020
Merged
Fix routingDataSourceType not configured in helix rest#1309huizhilu merged 1 commit intoapache:masterfrom
huizhilu merged 1 commit intoapache:masterfrom
Conversation
narendly
approved these changes
Aug 24, 2020
alirezazamani
approved these changes
Aug 24, 2020
ec0eeeb to
bc0636d
Compare
Contributor
Author
|
Verified it works after this change. The reason why we don’t catch the defect in helix rest tests is we don’t run tests against multiZk enabled. I think we should do so. We'll enable this in another PR. This PR is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1308
Description
Routing data source type is not set in helix rest when creating a realm-aware zkclient. This PR sets the source type to HTTP in helix rest.
Tests
(List the names of added unit/integration tests)
(Before CI test pass, please copy & paste the result of "mvn test")
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)