Continue task pipeline if currentState is null#1329
Merged
alirezazamani merged 2 commits intoapache:masterfrom Aug 29, 2020
Merged
Continue task pipeline if currentState is null#1329alirezazamani merged 2 commits intoapache:masterfrom
alirezazamani merged 2 commits intoapache:masterfrom
Conversation
In this commit, if controller encounters null currentStates, it will continue the pipeline and TaskSchedulingStage.
NealSun96
requested changes
Aug 28, 2020
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskCurrentStateNull.java
Outdated
Show resolved
Hide resolved
NealSun96
requested changes
Aug 28, 2020
helix-core/src/test/java/org/apache/helix/integration/task/TestTaskCurrentStateNull.java
Show resolved
Hide resolved
narendly
approved these changes
Aug 29, 2020
Contributor
narendly
left a comment
There was a problem hiding this comment.
@alirezazamani could you update with your final commit message?
Author
|
This PR is ready to be merged. Final commit message: In this commit, if controller encounters null currentStates, it will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes Null currentState cause the TASK pipeline to be stuck #1322
Description
In this PR, if controller encounters null currentStates, it will continue the pipeline and TaskSchedulingStage. Also such currentState would not count toward the quota.
Tests
The following tests are written for this issue:
TestTaskCurrentStateNull
The following is the result of the "mvn test" command on the appropriate module:
Helix-Core:
The failed test passed when run individually.
mvn test -Dtest="TestEnableCompression,TestEnqueueJobs"
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)