Add HelixRestObjectNameFactory to create namespaced ObjectName#1357
Merged
huizhilu merged 1 commit intoapache:masterfrom Sep 22, 2020
Merged
Add HelixRestObjectNameFactory to create namespaced ObjectName#1357huizhilu merged 1 commit intoapache:masterfrom
huizhilu merged 1 commit intoapache:masterfrom
Conversation
c498cbb to
5343c88
Compare
jiajunwang
reviewed
Sep 15, 2020
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
Show resolved
Hide resolved
2795799 to
4510e75
Compare
huizhilu
commented
Sep 19, 2020
Contributor
Author
huizhilu
left a comment
There was a problem hiding this comment.
@jiajunwang Thanks for the review and discussion. I've updated the lib version. Also ELR the libs to our internal artifactory to be ready.
4510e75 to
e838a26
Compare
4 tasks
dcc27a7 to
1b40fc5
Compare
jiajunwang
reviewed
Sep 21, 2020
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
Outdated
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
Show resolved
Hide resolved
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java
Show resolved
Hide resolved
junkaixue
reviewed
Sep 21, 2020
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestObjectNameFactory.java
Show resolved
Hide resolved
junkaixue
approved these changes
Sep 21, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Left one question. Overall, LGTM. But please address other reviewers concerns.
9438949 to
c595e9f
Compare
4109c25 to
7735e57
Compare
jiajunwang
approved these changes
Sep 22, 2020
Contributor
Author
|
Thank @dasahcc @jiajunwang for the review! This PR is ready to be merged, approved by @dasahcc @jiajunwang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #1356
Description
We need helix rest service metrics for each namespace. To achieve this, the namespace info needs to be contained in the MBean's object name, eg:
domain:name=getClusters,namespace=myNamespace,type=counters. But DropWizard's default ObjectNameFactory doesn't have the namespace parameter.This PR implements a custom object name factory and add the namespace to object name.
Tests
TestHelixRestObjectNameFactory
Final run:
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)