Skip to content

Implement deleteTask API#1468

Merged
alirezazamani merged 9 commits intoapache:masterfrom
alirezazamani:delete_task
Nov 3, 2020
Merged

Implement deleteTask API#1468
alirezazamani merged 9 commits intoapache:masterfrom
alirezazamani:delete_task

Conversation

@alirezazamani
Copy link

@alirezazamani alirezazamani commented Oct 15, 2020

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    In this PR, the changes that needed to delete an existing task from a general job have been added to TaskDriver.
    Also, the changes that needed on the controller side to drop the task from the instances and removing the task from the
    context has been implemented.

Tests

  • The following tests are written for this issue:
    TestAddDeleteTask

  • The following is the result of the "mvn test" command on the appropriate module:

[INFO] Tests run: 1242, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5,182.218 s - in TestSuite
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1242, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:26 h
[INFO] Finished at: 2020-10-31T15:48:43-07:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Ali Reza Zamani Zadeh Najari added 8 commits October 29, 2020 22:58
In this commit, the changes that needed to delete an existing
task from a general job has been added to TaskDriver.
Also, the changes that needed on the controller side to drop
the task from the instances and removing the task from the
context have been implemented.
Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic looks good.

@alirezazamani
Copy link
Author

This PR is ready to be merged.

Final commit message:

Implement deleteTask API

In this commit, the changes needed to delete an existing
task from a general job have been added to TaskDriver.
Also, the changes that are needed on the controller side to
drop the task from the instances and remove the task from the
context have been implemented.

@alirezazamani alirezazamani merged commit fbd3aab into apache:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete a tasks from the running (IN-PROGRESS) jobs or the jobs that have not started yet

5 participants