Merged
Conversation
7c457c5 to
13cbfff
Compare
huizhilu
reviewed
Oct 17, 2020
helix-core/src/test/java/org/apache/helix/integration/task/TestAddDeleteTask.java
Outdated
Show resolved
Hide resolved
a41a856 to
41b49d2
Compare
jiajunwang
reviewed
Oct 22, 2020
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Oct 26, 2020
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
huizhilu
reviewed
Oct 26, 2020
helix-core/src/main/java/org/apache/helix/task/JobDispatcher.java
Outdated
Show resolved
Hide resolved
NealSun96
requested changes
Oct 29, 2020
helix-core/src/main/java/org/apache/helix/task/FixedTargetTaskAssignmentCalculator.java
Outdated
Show resolved
Hide resolved
added 8 commits
October 29, 2020 22:58
In this commit, the changes that needed to delete an existing task from a general job has been added to TaskDriver. Also, the changes that needed on the controller side to drop the task from the instances and removing the task from the context have been implemented.
8ab62fd to
fc33115
Compare
junkaixue
reviewed
Nov 2, 2020
helix-core/src/main/java/org/apache/helix/task/GenericTaskAssignmentCalculator.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/task/ThreadCountBasedTaskAssignmentCalculator.java
Outdated
Show resolved
Hide resolved
junkaixue
approved these changes
Nov 2, 2020
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Overall logic looks good.
Author
|
This PR is ready to be merged. Final commit message: Implement deleteTask API In this commit, the changes needed to delete an existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes Delete a tasks from the running (IN-PROGRESS) jobs or the jobs that have not started yet #1467
Description
In this PR, the changes that needed to delete an existing task from a general job have been added to TaskDriver.
Also, the changes that needed on the controller side to drop the task from the instances and removing the task from the
context has been implemented.
Tests
The following tests are written for this issue:
TestAddDeleteTask
The following is the result of the "mvn test" command on the appropriate module:
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)