fix TestCleanupExternalView.test #1492
Merged
jiajunwang merged 2 commits intoapache:masterfrom Nov 4, 2020
Merged
Conversation
Flaky test with 10 * 100ms. This may not be enough when there is logging or Zk is slow in github.
jiajunwang
reviewed
Oct 29, 2020
helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java
Outdated
Show resolved
Hide resolved
zhangmeng916
reviewed
Nov 2, 2020
helix-core/src/test/java/org/apache/helix/integration/TestCleanupExternalView.java
Show resolved
Hide resolved
Contributor
Author
|
This diff is approved. Please help to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
fix #1458
Description
Flaky test with 10 * 100ms. This may not be enough when there is
logging or Zk is slow in github. Fix with TestHelper.verify();
Tests
(List the names of added unit/integration tests)
github run
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)