Skip to content

fix TestCleanupExternalView.test #1492

Merged
jiajunwang merged 2 commits intoapache:masterfrom
kaisun2000:TestCleanupExternalView_#1458
Nov 4, 2020
Merged

fix TestCleanupExternalView.test #1492
jiajunwang merged 2 commits intoapache:masterfrom
kaisun2000:TestCleanupExternalView_#1458

Conversation

@kaisun2000
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

fix #1458

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Flaky test with 10 * 100ms. This may not be enough when there is
    logging or Zk is slow in github. Fix with TestHelper.verify();

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

github run

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Flaky test with 10 * 100ms. This may not be enough when there is
logging or Zk is slow in github.
Copy link
Contributor

@zhangmeng916 zhangmeng916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaisun2000
Copy link
Contributor Author

This diff is approved. Please help to merge

Flaky test with 10 * 100ms. This may not be enough when there is
logging or Zk is slow in github. Fix with TestHelper.verify();

@jiajunwang jiajunwang merged commit 26ff60b into apache:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix TestCleanupExternalView.test

3 participants

Comments