Add default message handling retry count for state transition messages.#1514
Merged
Conversation
junkaixue
reviewed
Nov 10, 2020
The retry count will be counted when message handler creation fails or state transition times out. In addition, this PR also improves several ambiguous behaviors that may block a normal retry. 1. The cache of known messages list in HelixTaskExecutor may not be updated correctly if a message is going to be retried. 2. The retry count is not strictly followed in some conditions. 3. The to-be-retried message won't be automatically read when there is no other new message changes. Finally, improve the tests to cover the new changes.
58a0448 to
be3f7fa
Compare
Contributor
Author
|
Rebased to the current master and retested. [INFO] Results: |
jiajunwang
commented
Nov 10, 2020
junkaixue
approved these changes
Nov 12, 2020
Contributor
Author
|
Thank @dasahcc for the approval. I will merge the code soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #1513
Description
The retry count will be counted when message handler creation fails or state transition times out.
In addition, this PR also improves several ambiguous behaviors that may block a normal retry.
Finally, improve the tests to cover the new changes.
Tests
TestStateTransitionAppFailureHandling
[ERROR] Failures:
[ERROR] TestTaskRebalancerFailover.test » ThreadTimeout Method org.testng.internal.Tes...
[INFO]
[ERROR] Tests run: 1247, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:36 h
[INFO] Finished at: 2020-11-06T00:46:51-08:00
[INFO] ------------------------------------------------------------------------
Rerun the test and it will pass. But it is not stable due to issue #1512
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)