Fix several tests with resource leakage#1534
Merged
jiajunwang merged 6 commits intoapache:masterfrom Nov 18, 2020
Merged
Conversation
jiajunwang
reviewed
Nov 17, 2020
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
Show resolved
Hide resolved
xyuanlu
reviewed
Nov 18, 2020
...ore/src/test/java/org/apache/helix/controller/changedetector/TestResourceChangeDetector.java
Outdated
Show resolved
Hide resolved
jiajunwang
approved these changes
Nov 18, 2020
Contributor
jiajunwang
left a comment
There was a problem hiding this comment.
Please address the other comments.
Contributor
Author
|
This PR is approved, please help to merge in.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
fix #1226
Description
Fix several tests with resource leakage
Tests
(List the names of added unit/integration tests)
github run pending
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)