Skip to content

Fix several tests with resource leakage#1534

Merged
jiajunwang merged 6 commits intoapache:masterfrom
kaisun2000:flaky_test_leak
Nov 18, 2020
Merged

Fix several tests with resource leakage#1534
jiajunwang merged 6 commits intoapache:masterfrom
kaisun2000:flaky_test_leak

Conversation

@kaisun2000
Copy link
Contributor

@kaisun2000 kaisun2000 commented Nov 17, 2020

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

fix #1226

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Fix several tests with resource leakage

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:
    github run pending

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the other comments.

@kaisun2000
Copy link
Contributor Author

This PR is approved, please help to merge in.

Fix several tests with resource leakage

@jiajunwang jiajunwang merged commit 540c53b into apache:master Nov 18, 2020
@kaisun2000 kaisun2000 mentioned this pull request Nov 19, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checking Resource Leak at end of a test class

3 participants