Skip to content

Fix the unstable test TestWagedNodeSwap.#1738

Merged
jiajunwang merged 1 commit intoapache:masterfrom
jiajunwang:nodeSwap
May 17, 2021
Merged

Fix the unstable test TestWagedNodeSwap.#1738
jiajunwang merged 1 commit intoapache:masterfrom
jiajunwang:nodeSwap

Conversation

@jiajunwang
Copy link
Contributor

@jiajunwang jiajunwang commented May 14, 2021

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #1737

Description

  • Here are some details about my PR, including screenshots of any UI changes:

The original verifier may not check every DB before returns. This fails the following test cases occasionally.
This PR fixed the verifier. It also adds some randomize to the test.

Tests

  • The following tests are written for this issue:

Pure test fix for TestWagedNodeSwap.

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

The original verifier may not check every DB before returns. This fails the following test cases occasionally.
This PR fixed the verifier. It also add some randomize to the test.
@jiajunwang
Copy link
Contributor Author

Approved by @alirezazamani , ready to me merged.

@jiajunwang jiajunwang merged commit 481d548 into apache:master May 17, 2021
@jiajunwang jiajunwang deleted the nodeSwap branch May 17, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test TestWagedNodeSwap is unstable

2 participants