Add live instance data change listener#1745
Closed
huizhilu wants to merge 1 commit intoapache:cluster-pause-modefrom
Closed
Add live instance data change listener#1745huizhilu wants to merge 1 commit intoapache:cluster-pause-modefrom
huizhilu wants to merge 1 commit intoapache:cluster-pause-modefrom
Conversation
| listenerClass = LiveInstanceDataChangeListener.class; | ||
| break; | ||
| default: | ||
| logger.warn("Unexpected change type {} in callback {}", _changeType, _uid); |
Contributor
There was a problem hiding this comment.
This is a new case. I think if we do arrive at this case, we should log it as an error.
| _clusterName); | ||
| // Selectively refresh live instances cache. | ||
| notifyCaches(context, ChangeType.LIVE_INSTANCE); | ||
| pushToEventQueues(ClusterEventType.LiveInstanceChange, context, Collections.emptyMap()); |
Contributor
There was a problem hiding this comment.
Do we want to reuse the previous event type? If this is a new use case, we can have a new event type to distinguish individual instance data change from previous live instance children change.
| _manager.addLiveInstanceDataChangeListener(listener, instanceName); | ||
| accessor.updateProperty(accessor.keyBuilder().liveInstance(instanceName), liveInstance); | ||
|
|
||
| Assert.assertTrue(liveInstanceDataChangeNotified.get()); |
Contributor
There was a problem hiding this comment.
I would suggest to use TestHelper.verify(() instead of directly "assert" to validate the results so that the test is more stable. You can take a look at other test cases in this file as an example.
| */ | ||
| default void addLiveInstanceDataChangeListener(LiveInstanceDataChangeListener listener, | ||
| String instanceName) { | ||
| throw new NotImplementedException("Not implemented"); |
Contributor
There was a problem hiding this comment.
This line is unnecessary, as following the pattern for most other listeners in this class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Resolves #1743
Description
For cluster pause mode feature: controller needs to listen to the live instance status change and resume the cluster from pause mode upon all live instances fully exit pause mode.
Add a new listener to controller and implement the callback. Listener type: DataChange
Tests
testLiveInstanceDataChangeListener
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)