Skip to content

[Replica Level Throttle] Add test cases for replica level throttling#1754

Merged
junkaixue merged 1 commit intoapache:replica_level_throttlefrom
junkaixue:master
May 26, 2021
Merged

[Replica Level Throttle] Add test cases for replica level throttling#1754
junkaixue merged 1 commit intoapache:replica_level_throttlefrom
junkaixue:master

Conversation

@junkaixue
Copy link
Contributor

@junkaixue junkaixue commented May 25, 2021

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

resolves #343

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This commit contains the test skeleton and multiple test cases for:

  1. Sinlge top state throttling/non-throttling
  2. Multi top states throttling/non-throttling

Tests

  • The following tests are written for this issue:

TestReplicaLevelThrottling.java

  • The following is the result of the "mvn test" command on the appropriate module:

[INFO] Tests run: 1263, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5,046.769 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1263, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-core ---
[INFO] Loading execution data file /home/jxue/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 895 classes
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:24 h
[INFO] Finished at: 2021-05-25T11:56:09-07:00
[INFO] Final Memory: 44M/1115M
[INFO] ------------------------------------------------------------------------

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@jiajunwang jiajunwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a very quick review and decide to give you a quick approval : ) It is for protecting your changes eventually, haha.

This commit contains the test skeleton and multiple test cases for:
1. Sinlge top state throttling/non-throttling
2. Multi top states throttling/non-throttling
@junkaixue junkaixue merged commit 61a30e7 into apache:replica_level_throttle May 26, 2021
junkaixue added a commit that referenced this pull request Jun 1, 2021
This commit contains the test skeleton and multiple test cases for:
1. Sinlge top state throttling/non-throttling
2. Multi top states throttling/non-throttling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants