Skip to content

Comments

Remove dependency to an old Jackson v1 library#1934

Merged
narendly merged 1 commit intoapache:masterfrom
aholowko:master
Jan 19, 2022
Merged

Remove dependency to an old Jackson v1 library#1934
narendly merged 1 commit intoapache:masterfrom
aholowko:master

Conversation

@aholowko
Copy link
Contributor

@aholowko aholowko commented Jan 14, 2022

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #1933

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Remove dependency to an old Jackson v1 library (org.codehaus.jackson:jackson-mapper-asl) affected by the critical vulnerability: CVE-2019-17267

Tests

  • The following tests are written for this issue:

no new tests

  • The following is the result of the "mvn test" command on the appropriate module:

No errors

[INFO] Reactor Summary for Apache Helix 1.0.3-SNAPSHOT:
[INFO] 
[INFO] Apache Helix ....................................... SUCCESS [  0.760 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [  2.533 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 14.239 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [02:21 min]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [  1.577 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [  01:26 h]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [  0.571 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [01:52 min]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 56.329 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [  0.241 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [  0.015 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [  1.533 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [  1.773 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager  SUCCESS [  2.060 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [  1.810 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [  1.910 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:32 h
[INFO] Finished at: 2022-01-14T22:57:58+01:00
[INFO] ------------------------------------------------------------------------

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@junkaixue
Copy link
Contributor

Thanks for contributing Apache Helix. Please follow our template to modify your existing PR: https://github.com/apache/helix/wiki/Pull-Request-Description-Template

…jackson-mapper-asl) affected by the critical vulnerability: CVE-2019-17267
@aholowko
Copy link
Contributor Author

@junkaixue The PR has been updated.

@narendly
Copy link
Contributor

@aholowko Thanks for the PR. The commit looks good to me. Let's get it merged once the CI pipeline finishes.

@narendly narendly merged commit 7af17a3 into apache:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency org.codehaus.jackson:jackson-mapper-asl:1.9.13 leads to critical vulnerability: CVE-2019-17267

3 participants