Skip to content

Fix web build and deployment Issue#2014

Merged
junkaixue merged 1 commit intoapache:masterfrom
junkaixue:master
Apr 4, 2022
Merged

Fix web build and deployment Issue#2014
junkaixue merged 1 commit intoapache:masterfrom
junkaixue:master

Conversation

@junkaixue
Copy link
Contributor

Issues

  • [] My PR addresses the following Helix issues and references them in the PR description:

Description

  • Here are some details about my PR, including screenshots of any UI changes:

It adds a repository to download from more than default Maven Central. Restlet files are missing from Maven Central. Force it to download from Maven Central can cause problem.

Tests

  • The following tests are written for this issue:

  • The following is the result of the "mvn test" command on the appropriate module:

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Helix :: Website ............................ SUCCESS [ 12.801 s]
[INFO] Apache Helix :: Website :: 0.9.8 ................... SUCCESS [ 7.016 s]
[INFO] Apache Helix :: Website :: 0.9.9 ................... SUCCESS [ 5.505 s]
[INFO] Apache Helix :: Website :: 1.0.1 ................... SUCCESS [ 5.600 s]
[INFO] Apache Helix :: Website :: 1.0.2 ................... SUCCESS [ 5.409 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 42.091 s
[INFO] Finished at: 2022-04-04T10:07:54-07:00
[INFO] Final Memory: 64M/960M
[INFO] ------------------------------------------------------------------------

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@junkaixue
Copy link
Contributor Author

This change is ready to be merged. Approved by @desaikomal

Commit message:
Fix website build and deployment.

@junkaixue junkaixue merged commit dff4708 into apache:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants