Skip to content

Add TTL and Container modes to BaseDataAccessor and its implementations#2107

Merged
NealSun96 merged 1 commit intoapache:zookeeper-api-ttlcontainerfrom
rabashizade:ttl
May 24, 2022
Merged

Add TTL and Container modes to BaseDataAccessor and its implementations#2107
NealSun96 merged 1 commit intoapache:zookeeper-api-ttlcontainerfrom
rabashizade:ttl

Conversation

@rabashizade
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #2081

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes.

Tests

  • The following tests are written for this issue:

Two tests (testSyncCreateWithTTL() and testSyncCreateContainer()) were added to TestZkBaseDataAccessor. In addition, testAsyncZkBaseDataAccessor() in the same class was modified to test the newly added API.

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@junkaixue junkaixue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I dont any other concerns.

Copy link
Contributor

@qqu0127 qqu0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address other comments. thanks

@rabashizade
Copy link
Contributor Author

rabashizade commented May 24, 2022

This PR is ready to be merged, approved by @qqu0127.

Final commit message:

Add TTL and Container modes to BaseDataAccessor and its implementations

This commit adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes.

@NealSun96 NealSun96 merged commit 3e9b8b1 into apache:zookeeper-api-ttlcontainer May 24, 2022
NealSun96 pushed a commit that referenced this pull request Jun 3, 2022
…ns (#2107)

This commit adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants