Add TTL and Container modes to BaseDataAccessor and its implementations#2107
Merged
NealSun96 merged 1 commit intoapache:zookeeper-api-ttlcontainerfrom May 24, 2022
Merged
Conversation
junkaixue
reviewed
May 20, 2022
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Overall, I dont any other concerns.
qqu0127
approved these changes
May 24, 2022
Contributor
qqu0127
left a comment
There was a problem hiding this comment.
LGTM, please address other comments. thanks
Contributor
Author
|
This PR is ready to be merged, approved by @qqu0127. Final commit message: Add TTL and Container modes to BaseDataAccessor and its implementations This commit adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes. |
NealSun96
pushed a commit
that referenced
this pull request
Jun 3, 2022
…ns (#2107) This commit adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2081
Description
This PR adds support for TTL and Container modes to BaseDataAccessor and its implementations by taking advantage of relevant API from ZkClient and its descendent classes.
Tests
Two tests (
testSyncCreateWithTTL()andtestSyncCreateContainer()) were added toTestZkBaseDataAccessor. In addition,testAsyncZkBaseDataAccessor()in the same class was modified to test the newly added API.(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)