Skip to content

Removed Error Log to Avoid Spam Logging #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NealSun96 merged 5 commits into from
Sep 13, 2022
Merged

Removed Error Log to Avoid Spam Logging #2201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdf6a00
Changed the log levels of ZkClient's Delete method and ZkBaseDataAcce…
Aug 31, 2022
99fb57d
Add assertions that children were deleted by accessor remove
Marcosrico Sep 1, 2022
808a9e4
Remove cuationary deletion of nodes before test
Marcosrico Sep 6, 2022
1efc918
Changed logging level in delete() and renamed test case for better cl…
Marcosrico Sep 6, 2022
9b83937
Removed unecessary log and conditional statements. Downgraded remove(…
Marcosrico Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,36 @@ public void testSyncRemove() {
System.out.println("END " + testName + " at " + new Date(System.currentTimeMillis()));
}

@Test
public void testDeleteNodeWithChildren() {
String root = _rootPath;

ZkBaseDataAccessor<ZNRecord> accessor = new ZkBaseDataAccessor<>(_gZkClient);

// CreateChildren
List<ZNRecord> records = new ArrayList<>();
List<String> paths = new ArrayList<>();
for (int i = 0; i < 10; i++) {
String msgId = "msg_" + i;
paths.add(PropertyPathBuilder.instanceMessage(root, "host_1", msgId));
records.add(new ZNRecord(msgId));
}
boolean[] success = accessor.createChildren(paths, records, AccessOption.PERSISTENT);

// Attempt to remove parent. Shouldn't throw an error or warning log.
// Should return True if recursive deletion succeeds.
Assert.assertTrue(accessor.remove(PropertyPathBuilder.instanceMessage(root, "host_1"), 0),
"Should return True despite log errors.");

// Assert child message nodes were removed when calling remove on parent
for (int i = 0; i < 10; i++) {
String msgId = "msg_" + i;
String path = PropertyPathBuilder.instanceMessage(root, "host_1", msgId);
boolean pathExists = _gZkClient.exists(path);
Assert.assertFalse(pathExists, "Message znode should have been removed by accessor msgId=" + msgId);
}
}

@Test
public void testSyncGet() {
String className = TestHelper.getTestClassName();
Expand Down
5 changes: 1 addition & 4 deletions zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,14 +2066,11 @@ public Object call() throws Exception {
success = true;
} catch (ZkNoNodeException e) {
success = false;
if (LOG.isDebugEnabled()) {
LOG.debug("zkclient {}, Failed to delete path {}, znode does not exist!", _uid, path);
}
LOG.debug("zkclient {}, Failed to delete path {}, znode does not exist!", _uid, path);
}
record(path, null, startT, ZkClientMonitor.AccessType.WRITE);
} catch (Exception e) {
recordFailure(path, ZkClientMonitor.AccessType.WRITE);
LOG.warn("zkclient {}, Failed to delete path {}! ", _uid, path, e);
throw e;
} finally {
long endT = System.currentTimeMillis();
Expand Down