Skip to content

2210/partition list expand bug#2211

Merged
NealSun96 merged 4 commits intoapache:masterfrom
micahstubbs:2210/partition-list-expand-bug
Sep 14, 2022
Merged

2210/partition list expand bug#2211
NealSun96 merged 4 commits intoapache:masterfrom
micahstubbs:2210/partition-list-expand-bug

Conversation

@micahstubbs
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2210

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR fixes a bug introduced by a breaking change in the ngx-datatable library sometime in the past.

It fixes the bug for the Partition List component, as well as all other affected components, namely:

  • Job List
  • Resource List
  • Workflow List

Tests

  • The following tests are written for this issue:

Commits

Code Quality

  • My diff has been formatted using Prettier

@micahstubbs
Copy link
Contributor Author

This PR is ready to be merged, approved by @somecodemonkey
Final commit message:

Fix partition-list row expand bug (#2210)

Update helix-front for a breaking change
introduced by dependency ngx-datatable

@micahstubbs
Copy link
Contributor Author

micahstubbs commented Sep 14, 2022

The CI Failure appears to be because of this ZooKeeper issue which is unrelated to these frontend changes:

 77392 [TestNGInvoker-testGetChildrenOnLargeNumChildren()] 
ERROR org.apache.helix.zookeeper.zkclient.ZkClient [] - 
Failed to get children for path /testGetChildrenOnLargeNumChildren 
because of connection loss. Number of children 110000 
exceeds limit 100000, aborting retry.

https://github.com/apache/helix/actions/runs/3048770554/jobs/4914181617#step:5:36

@NealSun96 NealSun96 merged commit a9a76fa into apache:master Sep 14, 2022
@micahstubbs micahstubbs deleted the 2210/partition-list-expand-bug branch September 14, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants