2210/partition list expand bug#2211
Merged
NealSun96 merged 4 commits intoapache:masterfrom Sep 14, 2022
Merged
Conversation
somecodemonkey
approved these changes
Sep 13, 2022
Contributor
Author
|
This PR is ready to be merged, approved by @somecodemonkey Fix partition-list row expand bug (#2210)Update helix-front for a breaking change |
qqu0127
approved these changes
Sep 13, 2022
Contributor
Author
|
The CI Failure appears to be because of this ZooKeeper issue which is unrelated to these frontend changes: 77392 [TestNGInvoker-testGetChildrenOnLargeNumChildren()]
ERROR org.apache.helix.zookeeper.zkclient.ZkClient [] -
Failed to get children for path /testGetChildrenOnLargeNumChildren
because of connection loss. Number of children 110000
exceeds limit 100000, aborting retry.https://github.com/apache/helix/actions/runs/3048770554/jobs/4914181617#step:5:36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#2210
Description
This PR fixes a bug introduced by a breaking change in the ngx-datatable library sometime in the past.
It fixes the bug for the Partition List component, as well as all other affected components, namely:
Tests
Commits
Code Quality