Skip to content

2212/ensure that create cluster button is visible [helix-front]#2213

Merged
NealSun96 merged 3 commits intoapache:masterfrom
micahstubbs:2212/create-cluster-button-bug
Sep 15, 2022
Merged

2212/ensure that create cluster button is visible [helix-front]#2213
NealSun96 merged 3 commits intoapache:masterfrom
micahstubbs:2212/create-cluster-button-bug

Conversation

@micahstubbs
Copy link
Contributor

@micahstubbs micahstubbs commented Sep 14, 2022

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fix #2212

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR ensures that the create cluster button is visible in the left sidebar in the cluster list view. This is done both by updating styles as well as by verifying that the current user is logged in after loading all clusters.

Screen Shot 2022-09-14 at 11 17 33 AM

Screen Shot 2022-09-14 at 11 19 22 AM

Tests

  • The following tests are written for this issue:

Commits

Code Quality

  • My diff has been formatted using Prettier

@micahstubbs
Copy link
Contributor Author

This PR is ready to be merged, approved by @somecodemonkey
Final commit message:

Ensure that create cluster button is visible [helix-front] (#2212)

Verify that current user is logged in after loading all clusters
to ensure that create cluster button is visible in left sidebar

@NealSun96 NealSun96 merged commit ee61ff4 into apache:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create cluster button is missing helix-front

3 participants