Skip to content

Comments

Fix minor unclean logics in rebalancer classes#2254

Merged
NealSun96 merged 1 commit intoapache:masterfrom
NealSun96:nealsun/minor-corrections
Oct 27, 2022
Merged

Fix minor unclean logics in rebalancer classes#2254
NealSun96 merged 1 commit intoapache:masterfrom
NealSun96:nealsun/minor-corrections

Conversation

@NealSun96
Copy link
Contributor

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #2253

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Cleaning up certain unclean logics that are always reported by IDEs.

Tests

  • The following tests are written for this issue:

N/A

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks

Copy link
Contributor

@qqu0127 qqu0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement.

@NealSun96 NealSun96 merged commit a31ce71 into apache:master Oct 27, 2022
Marcosrico pushed a commit to Marcosrico/helix that referenced this pull request Nov 15, 2022
Fix minor unclean logics in rebalancer classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor unclean logics in rebalancer classes

4 participants