Skip to content

change snapshot version for metaclient#2461

Merged
xyuanlu merged 1 commit intoapache:metaclientfrom
xyuanlu:metaclient
Apr 28, 2023
Merged

change snapshot version for metaclient#2461
xyuanlu merged 1 commit intoapache:metaclientfrom
xyuanlu:metaclient

Conversation

@xyuanlu
Copy link
Contributor

@xyuanlu xyuanlu commented Apr 27, 2023

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

#2237

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Update snapshot version for metaclient align with TOT of master branch

Tests

  • The following tests are written for this issue:

NA

  • The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 93.569 s - in org.apache.helix.view.integration.TestHelixViewAggregator
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
[INFO] 

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu xyuanlu marked this pull request as ready for review April 28, 2023 00:12
Copy link
Contributor

@desaikomal desaikomal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is required for testing. thanks

@xyuanlu
Copy link
Contributor Author

xyuanlu commented Apr 28, 2023

This PR is approved by @desaikomal // Thanks!

Commit message: change snapshot version for metaclient
Update snapshot version for metaclient align with TOT of master branch

@xyuanlu xyuanlu merged commit 53d3e67 into apache:metaclient Apr 28, 2023
xyuanlu added a commit that referenced this pull request May 20, 2023
Update snapshot version for metaclient align with TOT of master branch
xyuanlu added a commit that referenced this pull request Jun 2, 2023
Update snapshot version for metaclient align with TOT of master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants