Cleanup - Part 2 - isDebugEnabled() related#2483
Merged
xyuanlu merged 3 commits intoapache:masterfrom May 15, 2023
Merged
Conversation
qqu0127
reviewed
May 9, 2023
Contributor
qqu0127
left a comment
There was a problem hiding this comment.
I think even with SLFJ API, we still need to avoid string concatenation in the log in regard to performance. The internal check won't save us in that case.
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
Outdated
Show resolved
Hide resolved
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkEventThread.java
Outdated
Show resolved
Hide resolved
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkEventThread.java
Outdated
Show resolved
Hide resolved
added 2 commits
May 9, 2023 09:18
Xiaoyuan has a pending change related to code-cleanup: https://github.com/apache/helix/pull/2470/files This is part2 - remaining files. Testing done: mvn -q test is in-progress.
rahulrane50
approved these changes
May 9, 2023
Contributor
Author
|
This change has been reviewed and approved by @qqu0127 and @rahulrane50. Thanks for the review. |
xyuanlu
pushed a commit
to xyuanlu/helix
that referenced
this pull request
May 20, 2023
Code cleanup Co-authored-by: Komal Desai <kdesai@kdesai-mn1.linkedin.biz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xiaoyuan has a pending change related to code-cleanup: https://github.com/apache/helix/pull/2470/files
Issues
Fixes No need to do isDebugEnabled check in slf4j.Logger. #1521
Description
This is part2 - remaining files.
Xiaoyuan has a change out for review:
code clean up - debug log format #2470
This is cleaning up the remaining files.
(Write a concise description including what, why, how)
Tests
The following tests are written for this issue:
The following is the result of the "mvn test" command on the appropriate module:
Testing done:
mvn -q test is in-progress.
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
Changes that Break Backward Compatibility (Optional)
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
Documentation (Optional)
(Link the GitHub wiki you added)
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)