Skip to content

Comments

Cleanup - Part 2 - isDebugEnabled() related#2483

Merged
xyuanlu merged 3 commits intoapache:masterfrom
desaikomal:waged
May 15, 2023
Merged

Cleanup - Part 2 - isDebugEnabled() related#2483
xyuanlu merged 3 commits intoapache:masterfrom
desaikomal:waged

Conversation

@desaikomal
Copy link
Contributor

Xiaoyuan has a pending change related to code-cleanup: https://github.com/apache/helix/pull/2470/files

Issues

Description

This is cleaning up the remaining files.

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

  • The following is the result of the "mvn test" command on the appropriate module:
    Testing done:
    mvn -q test is in-progress.

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

Copy link
Contributor

@qqu0127 qqu0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even with SLFJ API, we still need to avoid string concatenation in the log in regard to performance. The internal check won't save us in that case.

Komal Desai added 2 commits May 9, 2023 09:18
Xiaoyuan has a pending change related to code-cleanup:
https://github.com/apache/helix/pull/2470/files

This is part2 - remaining files.

Testing done:
mvn -q test is in-progress.
Copy link
Contributor

@qqu0127 qqu0127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@desaikomal
Copy link
Contributor Author

This change has been reviewed and approved by @qqu0127 and @rahulrane50. Thanks for the review.
Commit message: Code cleanup

@xyuanlu xyuanlu merged commit 1f5c5c8 into apache:master May 15, 2023
@desaikomal desaikomal deleted the waged branch May 18, 2023 16:11
xyuanlu pushed a commit to xyuanlu/helix that referenced this pull request May 20, 2023
Code cleanup

Co-authored-by: Komal Desai <kdesai@kdesai-mn1.linkedin.biz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No need to do isDebugEnabled check in slf4j.Logger.

4 participants