HelixGatewayParticipant only send target state implementation#2890
Closed
zpinto wants to merge 1 commit intoapache:helix-gateway-servicefrom
Closed
HelixGatewayParticipant only send target state implementation#2890zpinto wants to merge 1 commit intoapache:helix-gateway-servicefrom
zpinto wants to merge 1 commit intoapache:helix-gateway-servicefrom
Conversation
…sitions to the targetState to the client application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Description
The intended behavior for HelixGateway is to only send the targetState to the client application. A major refactor of Helix internals will be required to achieve this, as the controller will send a state transition message for each state in the state machine instead of just the final target state.
Until that refactor, the gateway participant will consult the IdealState of the resource for the pending state transition and forward a shard assignment message that has a the to state from the IdealState instead. All following ST messages from the controller will be auto-completed and NOT forwarded to the participant, as the client is already in the target state.
Tests
Changes that Break Backward Compatibility (Optional)
NA
Documentation (Optional)
NA
Commits
Code Quality
(helix-style-intellij.xml if IntelliJ IDE is used)