Skip to content

[TEST PR] Prevent DROPPED messages when mapping cannot be computed #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GrantPSpencer wants to merge 1 commit into from
Closed

[TEST PR] Prevent DROPPED messages when mapping cannot be computed #3016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,12 @@ private void generateMessage(final Resource resource, final BaseControllerDataPr
// resourceStateMap. This instance may not have had been dropped by the rebalance strategy.
// This check is required to ensure that the instances removed from the ideal state stateMap
// are properly dropped.
// This should only solve for instance operation case where the instance is removed from the statemap but there
// are still valid assignments in the mapping. We should not consider case where there is no mapping at all for
// the resource, which can occur on a rebalance failure. If the resource has been removed, the BP will
// contain the DROPPED states
for (String instance : currentStateMap.keySet()) {
if (!instanceStateMap.containsKey(instance)) {
if (!instanceStateMap.isEmpty() && !instanceStateMap.containsKey(instance)) {
instanceStateMap.put(instance, HelixDefinedState.DROPPED.name());
}
}
Expand Down