Skip to content

Fix dropping error state partition for customized resource#3024

Merged
xyuanlu merged 2 commits intoapache:masterfrom
xyuanlu:fixcustmerror
May 1, 2025
Merged

Fix dropping error state partition for customized resource#3024
xyuanlu merged 2 commits intoapache:masterfrom
xyuanlu:fixcustmerror

Conversation

@xyuanlu
Copy link
Copy Markdown
Contributor

@xyuanlu xyuanlu commented Apr 24, 2025

Issues

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Fix dropping error state partition for customized resource

Tests

  • The following tests are written for this issue:

testErrorReplicaPersist

  • The following is the result of the "mvn test" command on the appropriate module:

(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)

Changes that Break Backward Compatibility (Optional)

  • My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@xyuanlu
Copy link
Copy Markdown
Contributor Author

xyuanlu commented May 1, 2025

Rerun test and passed.

This PR is ready to be merged. Approved by @junkaixue @MarkGaox // Thanks!
Commit message: [Fix dropping error state partition for customized resource]

@xyuanlu xyuanlu merged commit def71b5 into apache:master May 1, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants