#328 Exclude ANY_INSTANCE for customized sibling checks #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition with 1 replica, there is no need to check sibling health status. This commit fixes issue apache#328
jiajunwang
approved these changes
Jul 10, 2019
Member
|
5 tests fails, should we fix the tests? |
Contributor
Author
There is only 1 test is unstable. We will try to fix it. I run it locally again, they all passed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition with 1 replica, there is no need to check sibling health status.
This commit fixes issue #328
TEST RESULT:
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestWorkflowTermination.testWorkflowSucceed:89->verifyWorkflowCleanup:256 expected: but was:
[INFO]
[ERROR] Tests run: 834, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 59:42 min
[INFO] Finished at: 2019-07-09T17:51:09-07:00
[INFO] Final Memory: 30M/981M
[INFO] ------------------------------------------------------------------------
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.637 s - in org.apache.helix.integration.task.TestWorkflowTermination
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44.461 s
[INFO] Finished at: 2019-07-09T17:53:16-07:00
[INFO] Final Memory: 30M/988M
[INFO] ------------------------------------------------------------------------