Back-pressure handler in NettyHelixIPCService#4
Merged
asfgit merged 1 commit intoapache:masterfrom Sep 16, 2014
brandtg:master
Merged
Back-pressure handler in NettyHelixIPCService#4asfgit merged 1 commit intoapache:masterfrom brandtg:master
asfgit merged 1 commit intoapache:masterfrom
brandtg:master
Conversation
Member
|
Verified build and mvn test. LGTM. |
asfgit
pushed a commit
that referenced
this pull request
Sep 16, 2014
kaisun2000
referenced
this pull request
in kaisun2000/helix
Oct 2, 2020
# This is the 1st commit message: 09/28 fix race condition t1 # This is the commit message #2: 09/28 fix race condition t2 # This is the commit message #3: 09/28 fix race condition t3 # This is the commit message #4: 09/28 fix race condition t4 # This is the commit message #5: 09/28 fix race condition t5 # This is the commit message apache#6: 09/28 fix race condition t6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hack in which Netty Channel was periodically closed to allow Netty objects to be GC'ed in favor of properly using channel writability changed events.
Before calling
Channel#writeAndFlush, we callBackPressureHandler#waitUntilWritable, which will block if the channel is not writable until#channelWritabilityChangedis called.Ran
BenchmarkDriverlocally to verify that heap usage stays relatively low and constant when NIC saturated.