New topology-aware auto rebalance strategy and some fixes to the old AutoRebalanceStrategy #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei-xia
changed the title
| import com.google.common.base.Predicates; | ||
| import org.apache.helix.HelixException; | ||
| import org.apache.helix.ZNRecord; | ||
| import org.apache.helix.controller.rebalancer.strategy.crushMapping.CRUSHPlacementAlgorithm; |
Member
There was a problem hiding this comment.
can we keep the package name as crush instead of crushMapping
Member
|
this is great work Lei. Can you please paste the final mapping generated by default strategy v/s crush method. Also when would one chose one over the other. |
Member
|
lgtm |
Member
Author
|
Hi, Kishore. I am working on a wiki/doc to introduce new topology aware rebalance strategy with some of experimental results showing stats of distribution of partitions and movements during rebalacing. Will publish it once it is ready. |
…rtitions on disabled instances should be dropped in FULL_AUTO rebalance mode
…sed on CRUSH algorithm. Design doc is available at: https://cwiki.apache.org/confluence/display/HELIX/Helix+Topology-aware+Rebalance+Strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mainly contains a new topology-aware auto rebalance strategy based on CRUSH algorithm. The detailed design doc is at: https://cwiki.apache.org/confluence/display/HELIX/Helix+Topology-aware+Rebalance+Strategy
Commits: