Add CloudConfig operations#589
Merged
junkaixue merged 1 commit intoapache:helix-cloudfrom Dec 7, 2019
Merged
Conversation
50fcaaa to
d36e5ce
Compare
Author
|
@dasahcc When you get a chance, could you please review this PR based on our discussions? |
huizhilu
reviewed
Nov 15, 2019
helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java
Show resolved
Hide resolved
junkaixue
reviewed
Nov 18, 2019
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
90c1e77 to
2ba09c9
Compare
junkaixue
reviewed
Nov 22, 2019
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
junkaixue
approved these changes
Nov 25, 2019
Contributor
junkaixue
left a comment
There was a problem hiding this comment.
Overall, LGTM. Let's wait for module and naming finalized before checked.
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
301a520 to
bbba230
Compare
narendly
reviewed
Dec 2, 2019
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Dec 6, 2019
helix-core/src/main/java/org/apache/helix/cloud/CloudProvider.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
Author
|
This PR is ready to be merged, approved by @dasahcc. Title: Add CloudConfig Related Code Body: |
zhangmeng916
reviewed
Dec 6, 2019
helix-core/src/main/java/org/apache/helix/cloud/constants/CloudProvider.java
Outdated
Show resolved
Hide resolved
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
Outdated
Show resolved
Hide resolved
In order to move toward supporting cloud environments and autoregisterations, we need to add CloudConfig to Zookeeper. The code regarding CloudConfig is added. A new test has been added to check the correctness of the code.
13968e6 to
d389e93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes TODO: Add CloudConfig to support cluster creation in cloud environments #588 .
Description
In order to move toward supporting cloud environments, we need to add CloudConfig to Zookeeper. The CloudConfig information will be used by the participants for autojoining.
In this commit:
The code regarding CloudConfig is added. A new test has been added to check the correctness of the code.
Tests
A new test has been added. (TestCloudConfig)
Test Result 1: mvn test
[ERROR] Tests run: 883, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3,234.951 s <<< FAILURE! - in TestSuite
[ERROR] testTaskPerformanceMetrics(org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics) Time elapsed: 2.22 s <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics.testTaskPerformanceMetrics(TestTaskPerformanceMetrics.java:118)
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestTaskPerformanceMetrics.testTaskPerformanceMetrics:118 expected: but was:
[INFO]
[ERROR] Tests run: 883, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 53:59 min
[INFO] Finished at: 2019-11-12T15:32:39-08:00
[INFO] ------------------------------------------------------------------------
Test Result 2: mvn test -Dtest="TestTaskPerformanceMetrics"
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.397 s - in org.apache.helix.monitoring.mbeans.TestTaskPerformanceMetrics
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21.497 s
[INFO] Finished at: 2019-11-12T15:46:06-08:00
[INFO] ------------------------------------------------------------------------
Commits
Code Quality