Skip to content

Set helix style to only wrap if long for throws.#634

Merged
jiajunwang merged 1 commit intoapache:masterfrom
huizhilu:helix-style
Jan 15, 2020
Merged

Set helix style to only wrap if long for throws.#634
jiajunwang merged 1 commit intoapache:masterfrom
huizhilu:helix-style

Conversation

@huizhilu
Copy link
Contributor

@huizhilu huizhilu commented Nov 26, 2019

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

Fixes #633

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Currently throws key word is wrapped to next line. We want it to be wrapped if long.

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(Copy & paste the result of "mvn test")

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Code Quality

  • My diff has been formatted using helix-style.xml

@jiajunwang
Copy link
Contributor

@pkuwm Please confirm if we can merge this change by following the required submit steps.

@huizhilu
Copy link
Contributor Author

This PR is ready to be merged, approved by @narendly
Message:

Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.

@jiajunwang jiajunwang merged commit b969f38 into apache:master Jan 15, 2020
mgao0 pushed a commit to mgao0/helix that referenced this pull request Jan 21, 2020
Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.
narendly pushed a commit to narendly/helix that referenced this pull request Feb 9, 2020
Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.
narendly pushed a commit to narendly/helix that referenced this pull request Feb 9, 2020
Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.
@huizhilu huizhilu deleted the helix-style branch February 11, 2020 08:08
mgao0 pushed a commit to mgao0/helix that referenced this pull request Mar 6, 2020
Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.
huizhilu added a commit to huizhilu/helix that referenced this pull request Aug 16, 2020
Currently key word throws is always wrapped to next line. This commit makes it only wrapped if long.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set helix style to only wrap throws key word if long

3 participants